propagateExceptionFinalResort-nodejs-reportError #4511
Conversation
|
@turansky PTAL! |
|
LGTM! |
|
|
| // https://github.com/JetBrains/kotlin-wrappers/blob/master/kotlin-browser/src/webMain/generated/web/errors/reportError.kt | ||
| if (globalThis.reportError != null) { | ||
| // Modern browsers, Deno, Bun, etc. | ||
| globalThis.reportError(jsException) |
There was a problem hiding this comment.
As I understand, we can only rely on reportError once your change in kotlin-wrappers is commited to master? So this PR is dependant on your merge.
| # Change log for kotlinx.coroutines | ||
|
|
||
| ## Version 1.10.3 | ||
| * Unhandled exceptions in Kotlin coroutines are now re-thrown into the environment instead of being logged into the console on the `js` and `wasmJS` targets. |
There was a problem hiding this comment.
I think mentioning that it still only prints to console in browser is not needed, since it, in fact, now throws in browser, only the browser chooses to log it into console.
Also, the logged exception message in browser may change, as it will now be formatted by the browser's preference, rather than by us.
| # Change log for kotlinx.coroutines | ||
|
|
||
| ## Version 1.10.3 | ||
| * Unhandled exceptions in Kotlin coroutines are now re-thrown into the environment instead of being logged into the console on the `js` and `wasmJS` targets. |
There was a problem hiding this comment.
Needs to be annotated as Breaking changes / Behavior change
| # Change log for kotlinx.coroutines | ||
|
|
||
| ## Version 1.10.3 | ||
| * Unhandled exceptions in Kotlin coroutines are now re-thrown into the environment instead of being logged into the console on the `js` and `wasmJS` targets. |
There was a problem hiding this comment.
We only update changelogs as part of the release procedure: https://github.com/Kotlin/kotlinx.coroutines/blob/master/RELEASE.md This way, several changes can be combined and described in bulk or undo one another.
|
|
||
| internal actual fun propagateExceptionFinalResort(exception: Throwable) { | ||
| val jsException = exception.toJsException() | ||
| // https://github.com/JetBrains/kotlin-wrappers/blob/master/kotlin-browser/src/webMain/generated/web/errors/reportError.kt |
There was a problem hiding this comment.
Using commit hashes instead of branch names can make such links more reliable. I wanted to say "this link could start returning 404 tomorrow", but in fact, it returns 404 for me today!
#4451